-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JShellAPI][Testing] Setting up First Integration Test - Simple code snippet evaluation scenario #50
[JShellAPI][Testing] Setting up First Integration Test - Simple code snippet evaluation scenario #50
Conversation
Note: this includes adding a 1st class for tests;
Note: this includes changes and improvements in gradle.build files;
3502cb7
to
c8747e1
Compare
… and test classes
I don't have time to do a review, so I'll just write here.
|
Hello @Alathreon !
I think that my test code is pretty simple, it uses WebTestClient API to establish test in a smooth way (ig it's a good practice as mentioned in spring docs) :
|
e7c2450
to
cccd5f1
Compare
JShellAPI/src/test/java/org/togetherjava/jshellapi/JShellApiTests.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/test/java/org/togetherjava/jshellapi/JShellApiTests.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/test/java/org/togetherjava/jshellapi/JShellApiTests.java
Outdated
Show resolved
Hide resolved
ae5fb7c
to
4f4ec50
Compare
JShellAPI/src/main/java/org/togetherjava/jshellapi/dto/JShellResult.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/rest/ApiEndpoints.java
Outdated
Show resolved
Hide resolved
362653c
to
89a7c65
Compare
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/test/java/org/togetherjava/jshellapi/JShellApiTests.java
Outdated
Show resolved
Hide resolved
89a7c65
to
1d77dfa
Compare
1d77dfa
to
8cc1485
Compare
Pull-request
Changes
Description
This PR is about setting up a first working integration test for JShellAPI only, it contains the following :
POST/jshel/eval
.Note: this PR is about setting the roadmap for testing strategy for JShellAPI only. It doesn't close the relevant issue.